jolshan commented on code in PR #15964:
URL: https://github.com/apache/kafka/pull/15964#discussion_r1603862201
##########
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorPartitionWriterTest.scala:
##########
@@ -84,98 +67,28 @@ class CoordinatorPartitionWriterTest {
}
@Test
- def testWriteRecords(): Unit = {
Review Comment:
Do we have an equivalent test for the writing of the records in
CoordinatorRuntimeTest? I didn't really notice new tests, but saw we have some
of the builder logic there. Is it tested by checking equality between the
records generated by the helper methods and the output from running the
CoordinatorRuntime code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
