nicktelford commented on PR #15975: URL: https://github.com/apache/kafka/pull/15975#issuecomment-2114986567
@mjsax @lucasbru @ableegoldman I know the vote hasn't closed yet, but I thought I'd get a head-start on the review. I'm submitting each metric from KIP-989 as a separate PR, to aid review, and because they can be merged independently. I think I've covered every Metered Iterator created; I searched for `Metered**Store` and found every Iterator constructed by them. Are there any that I've missed? Note: I'm not completely sold on the test strategy here. I'm currently calling one Iterator-creating method on each Metered store type (e.g. `all()` on `MeteredKeyValueStore`) - is this enough, or should I have a test for each Iterator-creating method each store provides? Might be somewhat overkill. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
