mjsax commented on code in PR #15975: URL: https://github.com/apache/kafka/pull/15975#discussion_r1607621599
########## streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/StateStoreMetrics.java: ########## @@ -144,6 +145,10 @@ private StateStoreMetrics() {} private static final String SUPPRESSION_BUFFER_SIZE_MAX_DESCRIPTION = MAX_DESCRIPTION_PREFIX + SUPPRESSION_BUFFER_SIZE_DESCRIPTION; + private static final String NUM_OPEN_ITERATORS = "num-open-iterators"; + private static final String NUM_OPEN_ITERATORS_DESCRIPTION = + "The current number of Iterators on the store that have been created, but not yet closed"; Review Comment: ```suggestion "The current number of iterators on the store that have been created, but not yet closed"; ``` ########## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java: ########## @@ -162,6 +165,8 @@ private void registerMetrics() { flushSensor = StateStoreMetrics.flushSensor(taskId.toString(), metricsScope, name(), streamsMetrics); deleteSensor = StateStoreMetrics.deleteSensor(taskId.toString(), metricsScope, name(), streamsMetrics); e2eLatencySensor = StateStoreMetrics.e2ELatencySensor(taskId.toString(), metricsScope, name(), streamsMetrics); + StateStoreMetrics.addNumOpenIteratorsGauge(taskId.toString(), metricsScope, name(), streamsMetrics, Review Comment: Would it be better to add a `Sensor` that allows us to track the different metrics in one go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org