lianetm commented on PR #15869: URL: https://github.com/apache/kafka/pull/15869#issuecomment-2134005505
Hey @Phuc-Hong-Tran , any update on this one? Let me know if you have any question. I also noticed that we should update the PR description to remove the reference to the old var name that was renamed, and I would also suggest we state what is done (not only how it's done). It should be helpful to explain that these are changes to avoid evaluating the subscription regex on every poll if metadata hasn't changed, identifying changes based on a metadata version snapshot. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
