showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1608010033
########## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ########## @@ -391,8 +398,10 @@ class UnifiedLogTest { assertNonEmptyFetch(log, offset, FetchIsolation.HIGH_WATERMARK) } - (log.highWatermark to log.logEndOffset).foreach { offset => - assertEmptyFetch(log, offset, FetchIsolation.HIGH_WATERMARK) + assertEmptyFetch(log, log.highWatermark, FetchIsolation.HIGH_WATERMARK) + + (log.highWatermark + 1 to log.logEndOffset).foreach { offset => Review Comment: With my [comment](https://github.com/apache/kafka/pull/15825#discussion_r1608007659), I think we don't need this change now, which makes this change smaller and safer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org