kamalcph commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1608823231
##########
storage/src/test/java/org/apache/kafka/tiered/storage/actions/EraseBrokerStorageAction.java:
##########
@@ -19,24 +19,35 @@
import org.apache.kafka.tiered.storage.TieredStorageTestAction;
import org.apache.kafka.tiered.storage.TieredStorageTestContext;
+import java.io.FilenameFilter;
import java.io.IOException;
import java.io.PrintStream;
public final class EraseBrokerStorageAction implements TieredStorageTestAction
{
private final int brokerId;
+ private final FilenameFilter filenameFilter;
+ private final boolean isStopped;
public EraseBrokerStorageAction(int brokerId) {
+ this(brokerId, (dir, name) -> true, false);
+ }
+
+ public EraseBrokerStorageAction(int brokerId,
+ FilenameFilter filenameFilter,
+ boolean isStopped) {
this.brokerId = brokerId;
+ this.filenameFilter = filenameFilter;
+ this.isStopped = isStopped;
}
@Override
public void doExecute(TieredStorageTestContext context) throws IOException
{
- context.eraseBrokerStorage(brokerId);
+ context.eraseBrokerStorage(brokerId, filenameFilter, isStopped);
}
@Override
public void describe(PrintStream output) {
- output.println("erase-broker-storage: " + brokerId);
+ output.println("erase-broker-storage: " + brokerId + ", isStopped: " +
isStopped);
Review Comment:
`filenameFilter` is a lambda expression, it results to the object name in
the log so omitted it from the output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
