edoardocomar commented on code in PR #15910:
URL: https://github.com/apache/kafka/pull/15910#discussion_r1608471528


##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointTaskTest.java:
##########
@@ -271,4 +284,102 @@ private Map<TopicPartition, Checkpoint> 
assertCheckpointForTopic(
         assertEquals(truth, checkpoints.containsKey(remoteTp), "should" + 
(truth ? "" : " not") + " emit offset sync");
         return checkpoints;
     }
+
+    @Test
+    public void testCheckpointsTaskRestartUsesExistingCheckpoints() {

Review Comment:
   Thanks - we fixed the reassignments. 
   We already load the OffsetSyncStore with different OffsetSync, but we think 
the CheckpointStore at restart of the task should contain the exact last 
checkpoint emitted by the previous instance of the task 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to