edoardocomar commented on code in PR #15910:
URL: https://github.com/apache/kafka/pull/15910#discussion_r1604720566


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##########
@@ -105,7 +106,10 @@ private KafkaBasedLog<byte[], byte[]> 
createBackingStore(MirrorCheckpointConfig
     /**
      * Start the OffsetSyncStore, blocking until all previous Offset Syncs 
have been read from backing storage.
      */
-    public void start() {
+    public void start(boolean initializationMustReadToEnd) {
+        this.initializationMustReadToEnd = initializationMustReadToEnd;
+        log.info("OffsetSyncStore initializationMustReadToEnd:{}{}", 
initializationMustReadToEnd,
+                initializationMustReadToEnd ? " - fewer checkpoints may be 
emitted" : "");

Review Comment:
   thanks we reworded the message where we catch the error, though we didn't 
write the offsets as there may be many groups handled by a task 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to