lianetm commented on code in PR #15869:
URL: https://github.com/apache/kafka/pull/15869#discussion_r1622564165
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1467,12 +1471,11 @@ public void assign(Collection<TopicPartition>
partitions) {
}
/**
- * TODO: remove this when we implement the KIP-848 protocol.
- *
* <p>
- * The contents of this method are shamelessly stolen from
- * {@link ConsumerCoordinator#updatePatternSubscription(Cluster)} and are
used here because we won't have access
- * to a {@link ConsumerCoordinator} in this code. Perhaps it could be
moved to a ConsumerUtils class?
+ *
+ * This function evaluate the regex that the consumer subscribed to
+ * against the list of topic names from metadata and update
Review Comment:
```suggestion
* against the list of topic names from metadata, and updates
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
