emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1617767952
########## clients/src/test/java/org/apache/kafka/common/metrics/stats/FrequenciesTest.java: ########## @@ -73,14 +72,14 @@ public void testMoreFrequencyParametersThanBuckets() { } @Test - public void testBooleanFrequencies() { + public void testBooleanFrequenciesStrategy1() { Review Comment: There were 3 scenarios inside single test, which effectively should have been reset the state of metric in between. But reset was based on the knowledge of internal implementation of samples/windows, which is not a part of class API and which was slightly changed. Now it is separated to different test methods to make reset explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org