emitskevich-blp commented on code in PR #15889:
URL: https://github.com/apache/kafka/pull/15889#discussion_r1617770678
##########
clients/src/test/java/org/apache/kafka/common/metrics/stats/FrequenciesTest.java:
##########
@@ -89,8 +88,17 @@ public void testBooleanFrequencies() {
}
assertEquals(0.25, falseMetric.stat().measure(config,
time.milliseconds()), DELTA);
assertEquals(0.75, trueMetric.stat().measure(config,
time.milliseconds()), DELTA);
+ }
- // Record 2 more windows worth of values
+ @Test
+ public void testBooleanFrequenciesStrategy2() {
Review Comment:
Tried just to keep all test scenarios as is to limit the scope of PR. So
didn't judge it deeply. Should we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
