kirktrue commented on code in PR #16031: URL: https://github.com/apache/kafka/pull/16031#discussion_r1618007950
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ########## @@ -235,7 +235,6 @@ public void addAll(final List<UnsentRequest> requests) { public void add(final UnsentRequest r) { Objects.requireNonNull(r); - r.setTimer(this.time, this.requestTimeoutMs); Review Comment: We provide the `Timer` when creating the `UnsentRequest`, so we don't need to add it afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org