kirktrue commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1618010264
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegateTest.java:
##########
@@ -123,23 +122,6 @@ public void testEnsureCorrectCompletionTimeOnComplete() {
assertEquals(timeMs, unsentRequest.handler().completionTimeMs());
}
- @Test
- public void testEnsureTimerSetOnAdd() {
- NetworkClientDelegate ncd = newNetworkClientDelegate();
- NetworkClientDelegate.UnsentRequest findCoordRequest =
newUnsentFindCoordinatorRequest();
- assertNull(findCoordRequest.timer());
-
- // NetworkClientDelegate#add
- ncd.add(findCoordRequest);
- assertEquals(1, ncd.unsentRequests().size());
- assertEquals(REQUEST_TIMEOUT_MS,
ncd.unsentRequests().poll().timer().timeoutMs());
-
- // NetworkClientDelegate#addAll
- ncd.addAll(Collections.singletonList(findCoordRequest));
- assertEquals(1, ncd.unsentRequests().size());
- assertEquals(REQUEST_TIMEOUT_MS,
ncd.unsentRequests().poll().timer().timeoutMs());
- }
-
Review Comment:
The `Timer` is provided via the constructor, so this test is no longer
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
