cmccabe commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1628473676


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4424,12 +4427,21 @@ private QuorumInfo createQuorumResult(final 
DescribeQuorumResponseData.Partition
                     .map(this::translateReplicaState)
                     .collect(Collectors.toList());
 
+                List<QuorumInfo.Node> nodes = nodeCollection.stream().map(n -> 
{
+                    List<Endpoint> endpoints = n.listeners().stream()
+                        .map(l -> new Endpoint(l.name(), 
SecurityProtocol.forId(l.securityProtocol()), l.host(), l.port()))

Review Comment:
   You should not be using Endpoint here since it's an internal class. Also we 
don't need/want to expose it in the admin API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to