cmccabe commented on code in PR #16106: URL: https://github.com/apache/kafka/pull/16106#discussion_r1628478358
########## clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java: ########## @@ -174,4 +194,22 @@ public String toString() { ')'; } } + + public static class Node { + private int nodeId; Review Comment: these need to be final. Also, we should understand what the result is for pre-KIP-853 nodes. Do they get an empty list of endpoints? That seems simple, but it needs to be spelled out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org