lianetm commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1636448307
########## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ########## @@ -435,7 +435,7 @@ public void shouldIgnoreGroupInstanceIdForEmptyGroupId(GroupProtocol groupProtoc } @ParameterizedTest - @EnumSource(GroupProtocol.class) + @EnumSource(value = GroupProtocol.class, names = "CLASSIC") Review Comment: This test does not apply to the new consumer anymore given that the new consumer unsubscribe now clears the subscription in the background as part of the leave operation. Tests covering subscribe and unsubscribe for the new consumer already exist in AsyncKafkaConsumerTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org