lianetm commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1638145262
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ########## @@ -673,7 +677,15 @@ public CompletableFuture<Void> leaveGroup() { CompletableFuture<Void> callbackResult = invokeOnPartitionsRevokedOrLostToReleaseAssignment(); callbackResult.whenComplete((result, error) -> { + if (error != null) { + log.error("Member {} callback to release assignment failed. Member will proceed " + + "to send leave group heartbeat", memberId, error); + } else { + log.debug("Member {} completed callback to release assignment and will send leave " + + "group heartbeat", memberId); + } // Clear the subscription, no matter if the callback execution failed or succeeded. + subscriptions.unsubscribe(); clearSubscription(); Review Comment: you're right, it's clearing assignments, renamed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org