OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1639046733
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java:
##########
@@ -437,6 +437,55 @@ public void testSendSyncEvent() {
verify(producer, times(5)).send(any(), any());
}
+ @Test
+ public void testDisableEmitOffsetSync() {
+ byte[] recordKey = "key".getBytes();
+ byte[] recordValue = "value".getBytes();
+ int maxOffsetLag = 50;
+ int recordPartition = 0;
+ int recordOffset = 0;
+ int metadataOffset = 100;
+ String topicName = "topic";
+ String sourceClusterName = "sourceCluster";
+
+ RecordHeaders headers = new RecordHeaders();
+ ReplicationPolicy replicationPolicy = new DefaultReplicationPolicy();
+
+ @SuppressWarnings("unchecked")
+ KafkaConsumer<byte[], byte[]> consumer = mock(KafkaConsumer.class);
+ @SuppressWarnings("unchecked")
+ KafkaProducer<byte[], byte[]> producer = mock(KafkaProducer.class);
+ MirrorSourceMetrics metrics = mock(MirrorSourceMetrics.class);
+ Semaphore outstandingOffsetSyncs = new Semaphore(1);
+ PartitionState partitionState = new PartitionState(maxOffsetLag);
+ Map<TopicPartition, PartitionState> partitionStates = new HashMap<>();
+
+ MirrorSourceTask mirrorSourceTask = new MirrorSourceTask(consumer,
metrics, sourceClusterName,
+ replicationPolicy, maxOffsetLag, producer,
outstandingOffsetSyncs, partitionStates, topicName, false);
+
+ SourceRecord sourceRecord = mirrorSourceTask.convertRecord(new
ConsumerRecord<>(topicName, recordPartition,
+ recordOffset, System.currentTimeMillis(),
TimestampType.CREATE_TIME, recordKey.length,
+ recordValue.length, recordKey, recordValue, headers,
Optional.empty()));
+
+ TopicPartition sourceTopicPartition =
MirrorUtils.unwrapPartition(sourceRecord.sourcePartition());
+ partitionStates.put(sourceTopicPartition, partitionState);
+ RecordMetadata recordMetadata = new
RecordMetadata(sourceTopicPartition, metadataOffset, 0, 0, 0, recordPartition);
+
+ ArgumentCaptor<Callback> producerCallback =
ArgumentCaptor.forClass(Callback.class);
+ when(producer.send(any(),
producerCallback.capture())).thenAnswer(mockInvocation -> {
+ producerCallback.getValue().onCompletion(null, null);
+ return null;
+ });
+
+ mirrorSourceTask.commitRecord(sourceRecord, recordMetadata);
Review Comment:
If am not sending `OffsetSyncWriter offsetSyncWriter` as null then how would
I know If it wasn't invoked?
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java:
##########
@@ -437,6 +437,55 @@ public void testSendSyncEvent() {
verify(producer, times(5)).send(any(), any());
}
+ @Test
+ public void testDisableEmitOffsetSync() {
+ byte[] recordKey = "key".getBytes();
+ byte[] recordValue = "value".getBytes();
+ int maxOffsetLag = 50;
+ int recordPartition = 0;
+ int recordOffset = 0;
+ int metadataOffset = 100;
+ String topicName = "topic";
+ String sourceClusterName = "sourceCluster";
+
+ RecordHeaders headers = new RecordHeaders();
+ ReplicationPolicy replicationPolicy = new DefaultReplicationPolicy();
+
+ @SuppressWarnings("unchecked")
+ KafkaConsumer<byte[], byte[]> consumer = mock(KafkaConsumer.class);
+ @SuppressWarnings("unchecked")
+ KafkaProducer<byte[], byte[]> producer = mock(KafkaProducer.class);
+ MirrorSourceMetrics metrics = mock(MirrorSourceMetrics.class);
+ Semaphore outstandingOffsetSyncs = new Semaphore(1);
+ PartitionState partitionState = new PartitionState(maxOffsetLag);
+ Map<TopicPartition, PartitionState> partitionStates = new HashMap<>();
+
+ MirrorSourceTask mirrorSourceTask = new MirrorSourceTask(consumer,
metrics, sourceClusterName,
+ replicationPolicy, maxOffsetLag, producer,
outstandingOffsetSyncs, partitionStates, topicName, false);
+
+ SourceRecord sourceRecord = mirrorSourceTask.convertRecord(new
ConsumerRecord<>(topicName, recordPartition,
+ recordOffset, System.currentTimeMillis(),
TimestampType.CREATE_TIME, recordKey.length,
+ recordValue.length, recordKey, recordValue, headers,
Optional.empty()));
+
+ TopicPartition sourceTopicPartition =
MirrorUtils.unwrapPartition(sourceRecord.sourcePartition());
+ partitionStates.put(sourceTopicPartition, partitionState);
+ RecordMetadata recordMetadata = new
RecordMetadata(sourceTopicPartition, metadataOffset, 0, 0, 0, recordPartition);
+
+ ArgumentCaptor<Callback> producerCallback =
ArgumentCaptor.forClass(Callback.class);
+ when(producer.send(any(),
producerCallback.capture())).thenAnswer(mockInvocation -> {
+ producerCallback.getValue().onCompletion(null, null);
+ return null;
+ });
+
+ mirrorSourceTask.commitRecord(sourceRecord, recordMetadata);
Review Comment:
If am sending `OffsetSyncWriter offsetSyncWriter` as null then how would I
know If it wasn't invoked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
