OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1639979561
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java:
##########
@@ -290,6 +290,11 @@ protected static ConfigDef config() {
.define(CLUSTERS_CONFIG, Type.LIST, Importance.HIGH,
CLUSTERS_DOC)
.define(ENABLE_INTERNAL_REST_CONFIG, Type.BOOLEAN, false,
Importance.HIGH, ENABLE_INTERNAL_REST_DOC)
.define(CONFIG_PROVIDERS_CONFIG, Type.LIST,
Collections.emptyList(), Importance.LOW, CONFIG_PROVIDERS_DOC)
+ .define(MirrorConnectorConfig.EMIT_OFFSET_SYNCS_ENABLED,
Review Comment:
How will we share the same config between source and checkpoint connectors?
I thought MirrorMakerConfig is the one that ensure this or am I missing
something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
