kamalcph commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641757420
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -412,7 +418,7 @@ public void onLeadershipChange(Set<Partition>
partitionsBecomeLeader,
Map<String, Uuid> topicIds) {
LOGGER.debug("Received leadership changes for leaders: {} and
followers: {}", partitionsBecomeLeader, partitionsBecomeFollower);
- if (this.rlmConfig.isRemoteStorageSystemEnabled() &&
!isRemoteLogManagerConfigured()) {
+ if (config.remoteLogManagerConfig().isRemoteStorageSystemEnabled() &&
!isRemoteLogManagerConfigured()) {
Review Comment:
yes, this is the main issue. We access the remote configurations using
`KafkaConfig.remoteLogManagerConfig.xyz()` but it reflects to the value in the
static server.properties file not the dynamically updated one.
So, changed the usages to `KafkaConfig.xyz()` to get the dynamically updated
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
