chia7712 commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1642698148
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -412,7 +418,7 @@ public void onLeadershipChange(Set<Partition>
partitionsBecomeLeader,
Map<String, Uuid> topicIds) {
LOGGER.debug("Received leadership changes for leaders: {} and
followers: {}", partitionsBecomeLeader, partitionsBecomeFollower);
- if (this.rlmConfig.isRemoteStorageSystemEnabled() &&
!isRemoteLogManagerConfigured()) {
+ if (config.remoteLogManagerConfig().isRemoteStorageSystemEnabled() &&
!isRemoteLogManagerConfigured()) {
Review Comment:
As we have great `RemoteLogManagerConfig` for remote storage, could we avoid
moving configs out of `RemoteLogManagerConfig`? Especially, we are trying to
reduce the size of `KafkaConfigs`.
If this PR aims to fix it for zk mode, maybe we can make sure the
`remoteLogManagerConfig` returned by `config` always has the latest configs.
For example:
1. `config.remoteLogManagerConfig` always create new
`remoteLogManagerConfig` based on `currentConfig`
2. `KafkaConfig#updateCurrentConfig` should update inner
`_remoteLogManagerConfig` also
@kamalcph WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
