satishd commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1642778901
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -412,7 +418,7 @@ public void onLeadershipChange(Set<Partition>
partitionsBecomeLeader,
Map<String, Uuid> topicIds) {
LOGGER.debug("Received leadership changes for leaders: {} and
followers: {}", partitionsBecomeLeader, partitionsBecomeFollower);
- if (this.rlmConfig.isRemoteStorageSystemEnabled() &&
!isRemoteLogManagerConfigured()) {
+ if (config.remoteLogManagerConfig().isRemoteStorageSystemEnabled() &&
!isRemoteLogManagerConfigured()) {
Review Comment:
@chia7712 Good point. A similar issue is raised in the
[comment](https://github.com/apache/kafka/pull/16353#pullrequestreview-2121953295).
We can fix the bug with the current approach in 3.8 and finish cleaning up the
raised issues in a followup as part of KAFKA-16976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
