OmniaGM commented on code in PR #15999: URL: https://github.com/apache/kafka/pull/15999#discussion_r1643099163
########## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnectorTest.java: ########## @@ -51,6 +51,30 @@ public class MirrorCheckpointConnectorTest { private static final String CONSUMER_GROUP = "consumer-group-1"; private static final Map<String, ?> SOURCE_OFFSET = MirrorUtils.wrapOffset(0); + @Test + public void testEmitCheckpointsAndSyncGroupOffsetsBothDisabled() { + // disable the checkpoint emission + MirrorCheckpointConfig config = new MirrorCheckpointConfig( + makeProps("emit.checkpoints.enabled", "false", + "sync.group.offsets.enabled", "false")); + + Set<String> knownConsumerGroups = new HashSet<>(); + knownConsumerGroups.add(CONSUMER_GROUP); + assertMirrorCheckpointConnectorDisabled(new MirrorCheckpointConnector(knownConsumerGroups, config)); + } + + @Test + public void testEmitOffsetSyncsDisabled() { Review Comment: I removed this now after doing some refactoring -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org