frankvicky commented on code in PR #16491: URL: https://github.com/apache/kafka/pull/16491#discussion_r1661081534
########## docs/ops.html: ########## @@ -3971,7 +3971,10 @@ <h3>Enter Migration Mode on the Brokers</h3> # KRaft controller quorum configuration controller.quorum.voters=3000@localhost:9093 -controller.listener.names=CONTROLLER</code></pre> +controller.listener.names=CONTROLLER + +# If the ZK broker is using a generated broker ID, disable broker ID generation +broker.id.generation.enable=false</code></pre> Review Comment: >If we don't add this line: broker.id.generation.enable=false, will it always fail? If `broker.id.generation.enable=true` and the user does not set `reserved.broker.max.id` to a value greater than -1, it will definitely fail; conversely, `broker.id.generation.enable=false` will make `reserved.broker.max.id` ineffective, so it will definitely not fail. >If the user needs to enable broker.id.generation.enable in their cluster because it has been working for years, what could they do? It is recommended that the user adjusts `reserved.broker.max.id` to a sufficiently large value to facilitate future migrations. ########## docs/ops.html: ########## @@ -3971,7 +3971,10 @@ <h3>Enter Migration Mode on the Brokers</h3> # KRaft controller quorum configuration controller.quorum.voters=3000@localhost:9093 -controller.listener.names=CONTROLLER</code></pre> +controller.listener.names=CONTROLLER + +# If the ZK broker is using a generated broker ID, disable broker ID generation +broker.id.generation.enable=false</code></pre> Review Comment: oh, as @chia7712 said, maybe the first question won't be a concern ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
