showuon commented on PR #16491:
URL: https://github.com/apache/kafka/pull/16491#issuecomment-2204748082
> 1. update docs to explain the possible error when you define the broker
id for the zk broker which is using broker.id.generation.enable
If my understanding is correct, the possible error is the broker id will be
ignored and the generated ID might exceed the range of max id, which cause the
error reported in JIRA. Is that right?
> 2. in order to minimize the changes, we can update both broker.id and
node.id together. The side effect is KafkaConfig#nodeId will be a mutable
variable.
IMO, this should be a bug. We should take the generated ID into node.id.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
