brenden20 commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1678342328
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -447,7 +505,8 @@ private ConsumerGroupHeartbeatRequest
getHeartbeatRequest(HeartbeatRequestManage
@ParameterizedTest
@MethodSource("errorProvider")
public void testHeartbeatResponseOnErrorHandling(final Errors error, final
boolean isFatal) {
- mockStableMember();
+ if (isFatal)
+ when(membershipManager.state()).thenReturn(MemberState.FATAL);
Review Comment:
Looks like the if statement was not necessary, the tests pass regardless.
Removing the assert and stubbing still make the test work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
