lianetm commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1681534114
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -898,6 +854,42 @@ private HeartbeatRequestManager
createHeartbeatRequestManager(
heartbeatState,
heartbeatRequestState,
backgroundEventHandler,
- metrics);
+ new Metrics());
+ }
+
+ private void mockJoiningMemberData(boolean instanceId) {
+ when(membershipManager.memberId()).thenReturn("");
+ when(membershipManager.memberEpoch()).thenReturn(0);
+ when(membershipManager.groupId()).thenReturn(DEFAULT_GROUP_ID);
+ if (instanceId)
+
when(membershipManager.groupInstanceId()).thenReturn(Optional.of(DEFAULT_GROUP_INSTANCE_ID));
+ else
+
when(membershipManager.groupInstanceId()).thenReturn(Optional.empty());
+
when(membershipManager.currentAssignment()).thenReturn(LocalAssignment.NONE);
+
when(membershipManager.serverAssignor()).thenReturn(Optional.of("uniform"));
+ when(membershipManager.state()).thenReturn(MemberState.UNSUBSCRIBED);
+ }
+
+ private void mockFencedToJoiningMemberData() {
+ when(membershipManager.state()).thenReturn(MemberState.JOINING);
+ when(membershipManager.memberEpoch()).thenReturn(0);
+ when(membershipManager.groupInstanceId()).thenReturn(Optional.empty());
+ }
+
+ private void mockDefaultMemberData(boolean instanceId) {
+ when(membershipManager.currentAssignment()).thenReturn(new
LocalAssignment(0, Collections.emptyMap()));
+ when(membershipManager.groupId()).thenReturn(DEFAULT_GROUP_ID);
+ when(membershipManager.memberId()).thenReturn(DEFAULT_MEMBER_ID);
+ when(membershipManager.memberEpoch()).thenReturn(DEFAULT_MEMBER_EPOCH);
+ if (instanceId)
+
when(membershipManager.groupInstanceId()).thenReturn(Optional.of(DEFAULT_GROUP_INSTANCE_ID));
+ else
+
when(membershipManager.groupInstanceId()).thenReturn(Optional.empty());
+
when(membershipManager.serverAssignor()).thenReturn(Optional.of("uniform"));
+ when(membershipManager.state()).thenReturn(MemberState.STABLE);
Review Comment:
Similar to previous comment. If this was needed to unblock asserts on
`membershipMgr.state()`, we should remove those assertions and this, as it
truly brings no value to test the expectation we set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
