kamalcph commented on code in PR #16615:
URL: https://github.com/apache/kafka/pull/16615#discussion_r1685730309
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -433,10 +433,13 @@ private void cacheTopicPartitionIds(TopicIdPartition
topicIdPartition) {
* @param partitionsBecomeLeader partitions that have become leaders on
this broker.
* @param partitionsBecomeFollower partitions that have become followers
on this broker.
* @param topicIds topic name to topic id mappings.
Review Comment:
Also, add javadoc for `validateTasksForTieredStateOfTopic`
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -1800,6 +1808,32 @@ public Future<Void> asyncRead(RemoteStorageFetchInfo
fetchInfo, Consumer<RemoteL
new RemoteLogReader(fetchInfo, this, callback,
brokerTopicStats, rlmFetchQuotaManager, remoteReadTimer));
}
+ void validateCopyAndExpireTasks(TopicIdPartition topicPartition, boolean
tieredStateOfTopic) {
Review Comment:
can we rename the `topicPartition` to `topicIdPartition` to avoid confusion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
