muralibasani commented on code in PR #16615:
URL: https://github.com/apache/kafka/pull/16615#discussion_r1687130977


##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -1800,6 +1808,32 @@ public Future<Void> asyncRead(RemoteStorageFetchInfo 
fetchInfo, Consumer<RemoteL
                 new RemoteLogReader(fetchInfo, this, callback, 
brokerTopicStats, rlmFetchQuotaManager, remoteReadTimer));
     }
 
+    void validateCopyAndExpireTasks(TopicIdPartition topicPartition, boolean 
tieredStateOfTopic) {

Review Comment:
   Yea we can, but I see this is the same pattern applied in other methods 
doHandleLeaderPartition doHandleFollowerPartition. I can update there too. Any 
suggestion on the name ?
   for ex here : 
   followerRLMTasks.computeIfAbsent(topicPartition, topicIdPartition -> {



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to