m1a2st commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1686438402
########## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java: ########## @@ -364,6 +364,10 @@ private static String convertDeprecatedClass(String className) { System.err.println("WARNING: kafka.tools.NoOpMessageFormatter is deprecated and will be removed in the next major release. " + "Please use org.apache.kafka.tools.consumer.NoOpMessageFormatter instead"); return NoOpMessageFormatter.class.getName(); + case "kafka.coordinator.transaction.TransactionLog$TransactionLogMessageFormatter": + System.err.println("WARNING: kafka.coordinator.transaction.TransactionLog$TransactionLogMessageFormatter is deprecated and will be removed in the next major release. " + + "Please use org.apache.kafka.tools.consumer.TransactionLogMessageFormatter instead"); + return className; Review Comment: If user want to use the old `TransactionLog$TransactionLogMessageFormatter`, we should let it work before we remove it, thus show the error message and let user use old formatter, I think is the good way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org