jolshan commented on code in PR #16719:
URL: https://github.com/apache/kafka/pull/16719#discussion_r1718867195
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -517,9 +526,19 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
val coordinatorEpoch = epochAndTxnMetadata.coordinatorEpoch
txnMetadata.inLock {
- if (txnMetadata.producerId != producerId)
+ producerIdCopy = txnMetadata.producerId
+ producerEpochCopy = txnMetadata.producerEpoch
+ val currentTxnMetadataIsAtLeastTransactionsV2 =
txnMetadata.clientTransactionVersion >= 2
+ if (txnMetadata.producerId != producerId &&
!(txnMetadata.previousProducerId == producerId && txnMetadata.producerEpoch ==
0 && currentTxnMetadataIsAtLeastTransactionsV2))
Review Comment:
Going to refactor this so it can also be used on line 638
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -517,9 +526,19 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
val coordinatorEpoch = epochAndTxnMetadata.coordinatorEpoch
txnMetadata.inLock {
- if (txnMetadata.producerId != producerId)
+ producerIdCopy = txnMetadata.producerId
+ producerEpochCopy = txnMetadata.producerEpoch
+ val currentTxnMetadataIsAtLeastTransactionsV2 =
txnMetadata.clientTransactionVersion >= 2
+ if (txnMetadata.producerId != producerId &&
!(txnMetadata.previousProducerId == producerId && txnMetadata.producerEpoch ==
0 && currentTxnMetadataIsAtLeastTransactionsV2))
Review Comment:
Going to refactor this so it can also be used on line 638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
