jolshan commented on code in PR #16719:
URL: https://github.com/apache/kafka/pull/16719#discussion_r1725793423
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -181,6 +183,7 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
newMetadata.producerEpoch,
TransactionResult.ABORT,
isFromClient = false,
+ clientTransactionVersion = 0,
Review Comment:
I was thinking about this some more. We can support setting 0 here and only
using the new epoch bump logic in the non prepareProducerFence/fromClient
cases. But I also wonder, since these are not even initiated by the client,
does the naming of this value even make sense? I do see that maybe we would
want to use the tagged fields and extra features, so I will probably just use
the server-side TV. But I am wondering if this name will be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
