frankvicky commented on code in PR #16876:
URL: https://github.com/apache/kafka/pull/16876#discussion_r1719302439
##########
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##########
@@ -95,13 +96,33 @@ public Builder setTargetTimes(List<ListOffsetsTopic>
topics) {
@Override
public ListOffsetsRequest build(short version) {
+ for (ListOffsetsTopic topic : data.topics()) {
+ for (ListOffsetsPartition partition : topic.partitions()) {
+ checkVersion(version, topic.name(), partition);
Review Comment:
Hi @chia7712
I have reviewed the code. Since `forConsumer` is a static method, if we aim
to perform a version check in this method, we will need to add a new argument.
I will try to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
