chia7712 commented on code in PR #16876:
URL: https://github.com/apache/kafka/pull/16876#discussion_r1719310204
##########
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##########
@@ -65,7 +66,8 @@ public static Builder forReplica(short allowedVersion, int
replicaId) {
public static Builder forConsumer(boolean requireTimestamp,
IsolationLevel isolationLevel,
boolean requireMaxTimestamp,
- boolean
requireTieredStorageTimestamp) {
+ boolean
requireTieredStorageTimestamp,
+ List<ListOffsetsTopic> topics) {
Review Comment:
Could you please follow the pattern? You can add a flag to pick up the min
version. Current implementation does not consider the version=8 and I feel that
is a kind of bug. @FrankYang0529 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
