gharris1727 commented on code in PR #16993: URL: https://github.com/apache/kafka/pull/16993#discussion_r1730041392
########## .gitignore: ########## @@ -54,8 +55,6 @@ systest/ jmh-benchmarks/generated jmh-benchmarks/src/main/generated **/.jqwik-database -**/src/generated -**/src/generated-test Review Comment: Removing these ignores makes it more likely for people to accidentally commit the generated code, right? WDYT about moving the directories but leaving the ignores in place for some time? If we merged my `clean` PR, that could give a window in which developers can clean up the old directories without ever thinking about them, and later we can finally remove the ignores and the extra `clean`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
