mumrah commented on code in PR #16993: URL: https://github.com/apache/kafka/pull/16993#discussion_r1730076337
########## .gitignore: ########## @@ -54,8 +55,6 @@ systest/ jmh-benchmarks/generated jmh-benchmarks/src/main/generated **/.jqwik-database -**/src/generated -**/src/generated-test Review Comment: The reason I wanted to remove it was so we could do a simple `git clean` to remove the files from the old location. However, not ignoring them does make it more likely for someone to commit them. I think your plan makes sense. Basically if we move the files to "build", but keep the additional clean logic you've added, `./gradlew clean` should clear out both locations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
