kamalcph commented on PR #17492: URL: https://github.com/apache/kafka/pull/17492#issuecomment-2415624320
@anshul35 Covering unit tests for deadlock might be tricky. We can skip them. Could you cover unit tests for the initialization failure? The existing [TopicBasedRemoteLogMetadataManagerTest](https://sourcegraph.com/github.com/apache/kafka/-/blob/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java) is an integration test. To simplify your test, you can add an unit test and mock the required behavior to throw exception while instantiating the ProducerManager or ConsumerManager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
