frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1810705740
##########
build.gradle:
##########
@@ -167,8 +167,10 @@ allprojects {
// ZooKeeper (potentially older and containing CVEs)
libs.nettyHandler,
libs.nettyTransportNativeEpoll,
- // be explicit about the reload4j version instead of relying on the
transitive versions
- libs.reload4j
+ libs.reload4j,
Review Comment:
Yes, there are still some modules (like `tools`) that directly depend on
`reload4j`, which we can't remove at the moment. Removing it would cause build
errors.
```
Execution failed for task ':tools:compileTestJava'.
> Could not resolve all files for configuration
':tools:testCompileClasspath'.
> Could not resolve ch.qos.reload4j:reload4j:1.2.25.
Required by:
project :tools
> Cannot find a version of 'ch.qos.reload4j:reload4j' that satisfies
the version constraints:
Dependency path 'org.apache.kafka:tools:4.0.0-SNAPSHOT' -->
'ch.qos.reload4j:reload4j:1.2.25'
Constraint path 'org.apache.kafka:tools:4.0.0-SNAPSHOT' -->
'ch.qos.reload4j:reload4j:{strictly 1.2.19}' because of the following reason:
version resolved in configuration ':tools:compileClasspath' by consistent
resolution
Dependency path 'org.apache.kafka:tools:4.0.0-SNAPSHOT' -->
'org.slf4j:slf4j-reload4j:1.7.36' (compile) -->
'ch.qos.reload4j:reload4j:1.2.19'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
