frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1812137033
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -3264,28 +3255,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
def describeBrokerLoggers(): Config =
client.describeConfigs(Collections.singletonList(brokerLoggerConfigResource)).values.get(brokerLoggerConfigResource).get()
- /**
- * Due to the fact that log4j is not re-initialized across tests, changing a
logger's log level persists across test classes.
- * We need to clean up the changes done while testing.
- */
- private def teardownBrokerLoggers(): Unit = {
Review Comment:
Yes, exactly.
`reconfigure()` provides a more convenient way to hot reload log4j
configurations. 😺
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
