showuon commented on code in PR #17575:
URL: https://github.com/apache/kafka/pull/17575#discussion_r1811764255
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {
(name, value) -> {
if ((int) value < -1 || (int) value == 0) throw new
ConfigException(name, value, "Value can be -1 or greater than 0");
},
- () -> REMOTE_LOG_MANAGER_THREAD_POOL_FALLBACK
+ () -> "[-1,1,...]"
Review Comment:
From the jdk javadoc, It looks like the
[ScheduledThreadPoolExecutor](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/concurrent/ScheduledThreadPoolExecutor.html#%3Cinit%3E(int))
can allow 0 as the corePoolSize. Maybe we can directly put the validator as
`atLeast(-1)`? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
