satishd commented on code in PR #17575:
URL: https://github.com/apache/kafka/pull/17575#discussion_r1811927922
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -104,7 +104,7 @@ public final class RemoteLogManagerConfig {
(name, value) -> {
if ((int) value < -1 || (int) value == 0) throw new
ConfigException(name, value, "Value can be -1 or greater than 0");
},
- () -> REMOTE_LOG_MANAGER_THREAD_POOL_FALLBACK
+ () -> "[-1,1,...]"
Review Comment:
What is the usecase for core pool size as 0 that is beneficial for users for
these configurations?
if somebody sets it as 0, it will be inefficient as it needs to create a
thread every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
