jolshan commented on code in PR #17597:
URL: https://github.com/apache/kafka/pull/17597#discussion_r1815692935
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -134,6 +134,12 @@ object StorageTool extends Logging {
case None =>
Option(config.originals.get(ReplicationConfigs.INTER_BROKER_PROTOCOL_VERSION_CONFIG)).
foreach(v =>
formatter.setReleaseVersion(MetadataVersion.fromVersionString(v.toString)))
}
+ Option(namespace.getList[String]("feature")).foreach(
Review Comment:
Previously we didn't allow for setting `release_version` and `feature`
flags. This was more of a problem when release_version set all the
corresponding features. Here, we may see metadata version in both places though
-- which takes precedence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
