cmccabe commented on code in PR #17597:
URL: https://github.com/apache/kafka/pull/17597#discussion_r1815708150
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -134,6 +134,12 @@ object StorageTool extends Logging {
case None =>
Option(config.originals.get(ReplicationConfigs.INTER_BROKER_PROTOCOL_VERSION_CONFIG)).
foreach(v =>
formatter.setReleaseVersion(MetadataVersion.fromVersionString(v.toString)))
}
+ Option(namespace.getList[String]("feature")).foreach(
Review Comment:
Features in general do take their defaults from `--release-version`. KIP-849
is just a bit special because it requires a special configuration and we didn't
want to make a breaking change. Then `--feature` takes priority over
`--release-version`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
