apoorvmittal10 commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1815087967
##########
server-common/src/main/java/org/apache/kafka/server/storage/log/FetchParams.java:
##########
@@ -42,6 +43,18 @@ public FetchParams(short requestVersion,
int maxBytes,
FetchIsolation isolation,
Optional<ClientMetadata> clientMetadata) {
+ this(requestVersion, replicaId, replicaEpoch, maxWaitMs, minBytes,
maxBytes, isolation, clientMetadata, false);
+ }
+
+ public FetchParams(short requestVersion,
+ int replicaId,
+ long replicaEpoch,
+ long maxWaitMs,
+ int minBytes,
+ int maxBytes,
+ FetchIsolation isolation,
+ Optional<ClientMetadata> clientMetadata,
+ boolean shareFetchRequest) {
Review Comment:
So ClientMetadata includes details for rackId, listenerName which I see in
regular fetch if utilized for figuring read replica. Not sure if that would be
relevant for ShareFetch in future and if we should skip always for ShareFetch.
Hence I have added the additional shareFetchBoolean. Please let me know what
you think. Also adding @junrao to provide his inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
