apoorvmittal10 commented on code in PR #16842:
URL: https://github.com/apache/kafka/pull/16842#discussion_r1819642232
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -127,7 +127,7 @@ public void onComplete() {
shareFetchData.future().complete(result);
} catch (Exception e) {
log.error("Error processing delayed share fetch request", e);
- shareFetchData.future().completeExceptionally(e);
+
sharePartitionManager.handleFetchException(shareFetchData.groupId(),
topicPartitionData.keySet(), shareFetchData.future(), e);
Review Comment:
As we are going with massive refactor with min bytes PR in delayed share
fetch, also the handling of this error will have it's own quite possible cases
hence created a jira to take that up in following PR:
https://issues.apache.org/jira/browse/KAFKA-17887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
