lianetm commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1817196108
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1520,6 +1523,9 @@ private Fetch<K, V> pollForFetches(Timer timer) {
return fetch;
}
+ // send any new fetches (won't resend pending fetches)
+ sendFetches(timer);
Review Comment:
well the `sendFetches` blocks until the `CreateFetchRequestsEvent`
completes, and that only happens on fetchMgr.poll
https://github.com/apache/kafka/blob/aae7e97fa041dac34a0788f90e837ff7f5ec3846/clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java#L115
So when the `sendFetches` completes we did poll the manager right? (and
depending on time, maybe we did poll the client.poll too, which happens in the
background right after polling all managers). That's why the log for "Polling
for fetches" made sense to me before the `sendFetches`, but am I missing
another poll happening after the log line maybe? (where it is now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
