lianetm commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1817277961
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1520,6 +1523,9 @@ private Fetch<K, V> pollForFetches(Timer timer) {
return fetch;
}
+ // send any new fetches (won't resend pending fetches)
+ sendFetches(timer);
Review Comment:
I surely didn't intend for you to put up that long response he he, sorry.
It's not about the log line per-se, it's about the alignment on where the poll
happens. The classic consumer logs "Polling for records", then calls
`client.poll`. vs us here we do `sendFetches` (which triggers the client.poll
async in the background thread because it blocks until we poll the fetch
manager), then log "Polling for fetches...".
That's the diff I saw and just wanted to understand/align on where the poll
happens: once we trigger `sendFetches` (blocking), the client.poll will happen
in the background anytime, not controlled by the app thread. Agreed? If so I'm
ok with leaving the log unchanged, understanding it could come out after the
client.poll happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
