dajac commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1820352389
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicMetadata.java:
##########
@@ -41,10 +41,25 @@ public class TopicMetadata {
*/
private final int numPartitions;
+ /**
+ * Map of every partition Id to a set of its rack Ids, if they exist.
+ * If rack information is unavailable for all partitions, this is an empty
map.
+ */
+ private final Map<Integer, Set<String>> partitionRacks;
Review Comment:
@FrankYang0529 Your proposal does not work because the changes may happen
when the group coordinator is offline. This is the reason why we have the
current mechanism in place. I think that we need to keep something similar.
Another thing is that we want to based this on the replicas set, not the ISR.
When a broker shutdowns, it remains in the replicas set. The adding/removing
replicas sets are only used when there is a reassignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
