chia7712 commented on code in PR #17625: URL: https://github.com/apache/kafka/pull/17625#discussion_r1823811195
########## tests/docker/Dockerfile: ########## @@ -13,10 +13,38 @@ # See the License for the specific language governing permissions and # limitations under the License. -# The base image of openjdk:17 is typically oraclelinux:8-slim, which doesn't include apt-get. -# Therefore, use openjdk:17-buster instead. -ARG jdk_version=openjdk:17-buster -FROM $jdk_version AS build-native-image +# We need to build the differnet versions of Java in same image, because the +# zookeeper client 3.4.x can't run under JDK 17, so we need to use JDK 11 in 2.1 ~ 2.3 +# kafka versions, see KAFKA-17888 +ARG os_version=ubuntu:latest +FROM $os_version AS build-native-image + +ARG jdk_11_version=11.0.2-linux-x64 +ARG jdk_11_url=https://s3-us-west-2.amazonaws.com/kafka-packages/jdk-${jdk_11_version}.tar.gz +ARG jdk_version=17-linux-x64 +ARG jdk_url=https://s3-us-west-2.amazonaws.com/kafka-packages/jdk-${jdk_version}.tar.gz Review Comment: > I think not everyone necessarily wants to test JDK 17, some might want to test JDK 21. That's why I named it a more neutral variable. that makes sense. Could you please rename it to "latest"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
