lucasbru commented on code in PR #17695:
URL: https://github.com/apache/kafka/pull/17695#discussion_r1831145709
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2288,18 +2259,40 @@ private
CoordinatorResult<StreamsGroupHeartbeatResponseData, CoordinatorRecord>
records
);
- if (bumpGroupEpoch || group.hasMetadataExpired(currentTimeMs)) {
- // The subscription metadata is updated when the refresh deadline
has been reached.
- subscriptionMetadata = group.computeSubscriptionMetadata(
+ // 2. Initialize/Update the group topology.
Review Comment:
I agree this method should be split. But splitting it now would make things
even more confusing, because there are 4 different heartbeat implementations
with similar sub-steps in this class. I know you don't like inline comments,
but let's postpone splitting this method to when we have split the
`GroupMetadataManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
